-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watcher: Expose isClosed method #1360
Conversation
@lburgazzoli can you please check this? |
@giri-vsr it would be nice to add a test |
Signed-off-by: Giri Ramasamy <46867712+giri-vsr@users.noreply.github.com>
@lburgazzoli Thanks. Test and method already exists. Just exposing Now I have updated the test to access |
@lburgazzoli anything else required? Also is it possible to do a release after this is merged? Thanks |
@giri-vsr I'll try to do a release this week |
Thanks |
@lburgazzoli Did you manage to do the release? |
no, will do this week. sorry for the delay |
@lburgazzoli No worries.Let me know once it is released Thanks |
@lburgazzoli Did you manage to do the release? |
@giri-vsr trying to release, but having issues with nexus/maven central |
0.8.2 should be synced to maven central soon |
Expose isClosed method on watcher so that we can restart the watch incase it is closed because of Errors.isHaltError(status) or Errors.isNoLeaderError(status)